Skip to content

SPLAT-2337: Added OTE binary for ccm-aws #30235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

SPLAT-2337: Added OTE binary for ccm-aws #30235

wants to merge 1 commit into from

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Sep 10, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2337 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Added binary to the OTE of a project cloud-provider-aws.

Related to:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2025
@mtulio mtulio force-pushed the SPLAT-2337-ote-ccm-aws branch 2 times, most recently from 2d904d4 to eaa43cf Compare September 17, 2025 19:33
This was referenced Sep 17, 2025
Open
Open
@mtulio
Copy link
Contributor Author

mtulio commented Sep 24, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

1 similar comment
@mtulio
Copy link
Contributor Author

mtulio commented Sep 24, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio mtulio mentioned this pull request Sep 24, 2025
Draft
@mtulio
Copy link
Contributor Author

mtulio commented Sep 25, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed during pre-provisioning: failed to create IAM roles: failed to create master instance profile: operation error IAM: CreateInstanceProfile, exceeded maximum number of attempts, 3, https response error StatusCode: 400, RequestID: 5387c91e-05d7-4bf5-a24c-b09dc9d8293c, api error Throttling: Rate exceeded

CI Infra issue while installing cluster / creating IAM roles (I wonder if we need a backoff/retry improvement in that part) - testing again:

@mtulio
Copy link
Contributor Author

mtulio commented Sep 25, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

1 similar comment
@mtulio
Copy link
Contributor Author

mtulio commented Sep 25, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio mtulio marked this pull request as ready for review October 1, 2025 21:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2025
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial October 1, 2025 21:07
@mtulio
Copy link
Contributor Author

mtulio commented Oct 2, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio mtulio marked this pull request as draft October 2, 2025 03:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Oct 2, 2025

Converting to draft, investigating issues on testwith in the original PR.

@mtulio
Copy link
Contributor Author

mtulio commented Oct 2, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio
Copy link
Contributor Author

mtulio commented Oct 2, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

I can build the image in ccm repo using the PR openshift/cloud-provider-aws#117 , let me try again.

$ make -f openshift-hack/Makefile image 
podman build \
	--authfile /home/me/.openshift/pull-secret-202509091449.json \
	-f Dockerfile.openshift \
	-t aws-cloud-controller-manager:v1.34.0-rc.0-307-gf3ac98762 .
[1/2] STEP 1/5: FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.20 AS builder

...
Successfully tagged localhost/aws-cloud-controller-manager:v1.34.0-rc.0-307-gf3ac98762
f2d8b099969f5774d915fa9e25a9151f28a2b2608cd070f8187e9ec97f05d7c3

@mtulio
Copy link
Contributor Author

mtulio commented Oct 2, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

1 similar comment
@mtulio
Copy link
Contributor Author

mtulio commented Oct 2, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio
Copy link
Contributor Author

mtulio commented Oct 2, 2025

The latest testwith ran correctly, with 5/7 tests failing. I just updated the CCM/OTE PR to address the issue. re-trying ^ (my last comment)

@mtulio
Copy link
Contributor Author

mtulio commented Oct 3, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio
Copy link
Contributor Author

mtulio commented Oct 3, 2025

something went wrong in the last rebase, I will remove the unrelated OTE commits soon in my next cycle.

@mtulio
Copy link
Contributor Author

mtulio commented Oct 3, 2025

Successful execution =)

I just converted the ccm-aws repo to ready for review with final changes. Triggering with latest version to ensure readiness after updating vedor:

@mtulio
Copy link
Contributor Author

mtulio commented Oct 3, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio mtulio force-pushed the SPLAT-2337-ote-ccm-aws branch from 2289cf4 to c295324 Compare October 9, 2025 17:59
@mtulio
Copy link
Contributor Author

mtulio commented Oct 9, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio
Copy link
Contributor Author

mtulio commented Oct 9, 2025

CI Infra issues:

time="2025-10-09T18:40:38Z" level=debug msg="\tfailed to create new managed VPC: failed to create vpc: VpcLimitExceeded: The maximum number of VPCs has been reached."

I will try it again in the next command

@mtulio
Copy link
Contributor Author

mtulio commented Oct 9, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

1 similar comment
@mtulio
Copy link
Contributor Author

mtulio commented Oct 10, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio
SPLAT-2337: Added OTE binary for ccm-aws
33eb0ad 
Added binary to the OTE of a project cloud-provider-aws.
@mtulio mtulio force-pushed the SPLAT-2337-ote-ccm-aws branch from c295324 to 33eb0ad Compare October 29, 2025 04:32
@mtulio
Copy link
Contributor Author

mtulio commented Oct 29, 2025

Testing after CCM-AWS 112 merged, and 117 rebased:
/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio
Copy link
Contributor Author

mtulio commented Oct 29, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117

@mtulio
Copy link
Contributor Author

mtulio commented Oct 29, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/cloud-provider-aws#117,openshift/cluster-cloud-controller-manager-operator#391

@mtulio
Copy link
Contributor Author

mtulio commented Oct 30, 2025 •
edited
Loading

Based in the results on job https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-origin-30235-openshift-cloud-provider-aws-117-e2e-aws-ovn/1983393761152995328 including the CCM-AWS OTE tests from upstream, I am converting this PR to ready for review holding until openshift/cloud-provider-aws#117 is merged and ote binary available in the payload.

/hold

@mtulio mtulio marked this pull request as ready for review October 30, 2025 19:06
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 30, 2025
@nrb
Copy link

nrb commented Oct 30, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio, nrb
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Contributor Author

mtulio commented Oct 30, 2025 •
edited
Loading

Hey Forrest / Stephen, would you mind taking a look, please?

cc @neisw @stbenjam

@mtulio
Copy link
Contributor Author

mtulio commented Oct 30, 2025

/retest

@openshift-trt
Copy link

openshift-trt bot commented Oct 31, 2025

Job Failure Risk Analysis for sha: 33eb0ad

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (27) are below the historical average (874): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (77) are below the historical average (1805): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-trt
Copy link

openshift-trt bot commented Oct 31, 2025

Job Failure Risk Analysis for sha: 33eb0ad

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (76) are below the historical average (1813): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (77) are below the historical average (3285): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (27) are below the historical average (1648): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (27) are below the historical average (874): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (75) are below the historical average (1808): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (76) are below the historical average (1700): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (77) are below the historical average (1805): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn IncompleteTests
Tests for this run (77) are below the historical average (3275): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (77) are below the historical average (1827): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (72) are below the historical average (2928): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn IncompleteTests
Tests for this run (74) are below the historical average (3355): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (72) are below the historical average (3385): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@mtulio
Copy link
Contributor Author

mtulio commented Oct 31, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-2of2 33eb0ad link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-ovn 33eb0ad link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift-serial 33eb0ad link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-microshift 33eb0ad link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-fips 33eb0ad link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn-upgrade 33eb0ad link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-serial-1of2 33eb0ad link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-vsphere-ovn-upi 33eb0ad link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-csi 33eb0ad link true /test e2e-gcp-csi
ci/prow/e2e-aws-csi 33eb0ad link true /test e2e-aws-csi
ci/prow/e2e-vsphere-ovn 33eb0ad link true /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 33eb0ad link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Oct 31, 2025

Job Failure Risk Analysis for sha: 33eb0ad

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (27) are below the historical average (1640): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (26) are below the historical average (869): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (77) are below the historical average (1798): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn IncompleteTests
Tests for this run (76) are below the historical average (3265): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (77) are below the historical average (1818): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn IncompleteTests
Tests for this run (74) are below the historical average (3340): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (73) are below the historical average (3374): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-trt
Copy link

openshift-trt bot commented Oct 31, 2025

Job Failure Risk Analysis for sha: 33eb0ad

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (75) are below the historical average (1804): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (77) are below the historical average (3270): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (27) are below the historical average (1640): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (26) are below the historical average (869): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (76) are below the historical average (1799): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (76) are below the historical average (1693): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (77) are below the historical average (1798): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn IncompleteTests
Tests for this run (76) are below the historical average (3265): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (77) are below the historical average (1818): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (72) are below the historical average (2914): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn IncompleteTests
Tests for this run (74) are below the historical average (3340): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (73) are below the historical average (3374): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@mtulio
Copy link
Contributor Author

mtulio commented Oct 31, 2025

Of course e2e won't pass as OTE PR for CCM-AWS is still open. 🤕

does not exist. the src path "/usr/bin/aws-cloud-controller-manager-tests-ext.gz" doesn't exist in image

Holding to prevent triggering jobs while not unblocked.

@mtulio mtulio marked this pull request as draft October 31, 2025 16:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@nrb nrb

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtulio @openshift-ci-robot @nrb